Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci/package_checks: Add exception for EULA as a package license #2438

Merged
merged 1 commit into from
May 1, 2024

Conversation

silkeh
Copy link
Member

@silkeh silkeh commented May 1, 2024

Summary

Add an exception for EULA, as that is used by the following packages:

hsa-amd-aqlprofile
intel-microcode
nvidia-470-glx-driver
nvidia-beta-driver
nvidia-developer-driver
nvidia-glx-driver
opencv

This is not a valid SPDX license identifier, but there is no valid alternative.

Resolves #2423

Test Plan

Verify the warning is no longer there:

$ ./common/CI/package_checks.py packages/i/intel-microcode/package.yml
Checking files: packages/i/intel-microcode/package.yml
Found 2 result(s), 1 warnings and 0 error(s)
INF packages/i/intel-microcode/package.yml:1: This package is included in the ISO. Consider validating the functionality in a newly built ISO.
WRN packages/i/intel-microcode/package.yml:1: Package release is not incremented by 1

**Summary**

Add an exception for `EULA`, as that is used by the following packages:

```
hsa-amd-aqlprofile
intel-microcode
nvidia-470-glx-driver
nvidia-beta-driver
nvidia-developer-driver
nvidia-glx-driver
opencv
```

This is not a valid SPDX license identifier, but there is no valid alternative.

Resolves #2423
Copy link
Contributor

@ermo ermo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ermo ermo merged commit b2478b6 into main May 1, 2024
2 checks passed
@ermo ermo deleted the add-spdx-exception branch May 1, 2024 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Exclude EULA from GitHub Actions / Checks
2 participants