-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make release workflow enable to trigger manually #173
Conversation
.github/workflows/release.yml
Outdated
tag: | ||
description: 'Tag to build and upload artifact bundle for' | ||
required: true | ||
default: ${{ github.ref_name }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this value is revision, can we update Zip files to the actual release?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can't upload in that case (for commit hashes).
.github/workflows/release.yml
Outdated
@@ -1,6 +1,12 @@ | |||
on: | |||
release: | |||
types: [created] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about adding updated
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
release
trigger: https://docs.github.com/en/actions/writing-workflows/choosing-when-your-workflow-runs/events-that-trigger-workflows#release
- published
- unpublished
- created
- edited
- deleted
- prereleased
- released
edited
is triggered only when the description is updated so that's not appropriate I think.
Looks like published
is better than created
.
A release, pre-release, or draft of a release was published.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure why but the release workflow for 0.27.0 didn't ran
That was because I created the release as a draft initially.
https://docs.github.com/en/webhooks/webhook-events-and-payloads?actionType=created#release
A draft was saved, or a release or pre-release was published without previously being saved as a draft.
I'm not sure why but the release workflow for 0.27.0 didn't ran. I added workflow_dispatch trigger for the workflow and would like to trigger that manually.