feat(GiniHealthSDK): UnitTests for GiniHealthSDK IPC-196 #473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…is payable IPC-194
…ayment provider app
… set document for review IPC-196
…nt components IPC-182
zladzeyka
reviewed
Apr 5, 2024
There was a problem hiding this comment.
Great job @razvancapra 👏🏻
and I love ❤️ the naming approach for the tests.
Could please check my 2 tiny comments?
HealthSDK/GiniHealthSDK/Sources/GiniHealthSDK/Core/GiniHealth.swift
Outdated
Show resolved
Hide resolved
HealthSDK/GiniHealthSDK/Sources/GiniHealthSDK/Core/GiniHealth.swift
Outdated
Show resolved
Hide resolved
HealthSDK/GiniHealthSDK/Sources/GiniHealthSDK/Core/URLOpener.swift
Outdated
Show resolved
Hide resolved
zladzeyka
reviewed
Apr 8, 2024
...APILibrary/GiniHealthAPILibrary/Sources/GiniHealthAPILibrary/Documents/DocumentService.swift
Outdated
Show resolved
Hide resolved
zladzeyka
reviewed
Apr 10, 2024
HealthSDK/GiniHealthSDK/Tests/GiniHealthSDKTests/MockHelpers/FileLoader.swift
Show resolved
Hide resolved
zladzeyka
approved these changes
Apr 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR contains tests for public methods/classes from GiniHealthSDK.
https://ginis.atlassian.net/browse/IPC-196
https://ginis.atlassian.net/browse/IPC-187
https://ginis.atlassian.net/browse/IPC-189
https://ginis.atlassian.net/browse/IPC-193
https://ginis.atlassian.net/browse/IPC-191