Tests : retrait des assertions dupliquées assertContains et assertRedirects #5550
+85
−201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EwenKorr
added
the
no-changelog
`assertContains` is also asserting the status code of the response.
EwenKorr
force-pushed
the
ewen/clean-asserts
branch
from
0b10a54 to
3909527
Compare
`assertRedirects` verifies the status code as well as the redirect URL. Therefore, prefer `assertRedirects` over `assert response.status_code == 302` or `assert response.url == next_url`.
EwenKorr
force-pushed
the
ewen/clean-asserts
branch
from
3909527 to
00f2429
Compare
xavfernandez
approved these changes
Feb 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 Pourquoi ?
assertContainsteste également lestatus_code, pas besoin de rappelerassert response.status_code == 200.De même,
assertRedirectsvérifie questatus_code == 302, et il est inutile de rappelerassert response.url == next_url.Nettoyage effectué dans
apply,job_seekers_viewsetgps.