Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates home overview - stale states and performance #3981

Merged
merged 5 commits into from
Jan 30, 2025
Merged

Updates home overview - stale states and performance #3981

merged 5 commits into from
Jan 30, 2025

Conversation

d13
Copy link
Member

@d13 d13 commented Jan 24, 2025 •
edited
Loading

  • Splits home overview state by active and inactive branches
  • Fixes unneeded overview refresh after opening the switch repo picker
  • Fixes unneeded overview refresh when subscription data doesn't change
  • Fixes repo file changes not reflecting while home that was made while home was hidden

@d13 d13 force-pushed the debt/split-home-overview-state branch 5 times, most recently from 2f303f2 to 2214abd Compare January 27, 2025 19:35
@d13 d13 changed the title Splits home overview state by active and inactive branches Updates home overview - stale states and performance Jan 28, 2025
@d13 d13 marked this pull request as ready for review January 28, 2025 17:01
@d13 d13 linked an issue Jan 28, 2025 that may be closed by this pull request
After making changes to a repository, the Home View doesn't reflect that there are working directory changes to commit. #3949
Closed
@d13 d13 removed a link to an issue Jan 28, 2025
After making changes to a repository, the Home View doesn't reflect that there are working directory changes to commit. #3949
Closed
@d13 d13 linked an issue Jan 28, 2025 that may be closed by this pull request
Home View doesn't update repo state changes made when hidden #3946
Closed
3 tasks
@d13 d13 force-pushed the debt/split-home-overview-state branch 2 times, most recently from 2c4e6e4 to 7384502 Compare January 29, 2025 22:05
@eamodio
Copy link
Member

eamodio commented Jan 29, 2025

Ultimately it would be good to split the set of branches and the real data of each branch, so that we can query independently

@d13 d13 force-pushed the debt/split-home-overview-state branch from 7384502 to dd67766 Compare January 30, 2025 18:46
@d13 d13 merged commit 6c4d4fe into main Jan 30, 2025
3 checks passed
@d13 d13 modified the milestone: 16.3 Jan 30, 2025
This was linked to issues Jan 30, 2025
After creating a new branch and checking it out, the Home View doesn't update the current branch without a manual refresh #3947
Closed
After committing changes to a repository in the SCM view, the Home view still shows that there are changes to be committed until manually refreshed. #3948
Closed
After making changes to a repository, the Home View doesn't reflect that there are working directory changes to commit. #3949
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eamodio eamodio eamodio left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@d13 @eamodio