Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Downloader: Add structured logging, fails storing and statistics #443

Merged
merged 23 commits into from
Aug 28, 2023
Merged

Downloader: Add structured logging, fails storing and statistics #443

merged 23 commits into from
Aug 28, 2023

Conversation

s-l-teichmann
Copy link
Contributor

@s-l-teichmann s-l-teichmann commented Aug 24, 2023 •
edited
Loading

Solves #397

ThomasJunk
ThomasJunk previously approved these changes Aug 25, 2023
View reviewed changes
Copy link
Contributor

@ThomasJunk ThomasJunk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and works!

@s-l-teichmann s-l-teichmann marked this pull request as draft August 25, 2023 15:08
@s-l-teichmann s-l-teichmann changed the title Downloader: Add structured logging Downloader: Add structured logging, fails storing Aug 25, 2023
@s-l-teichmann s-l-teichmann linked an issue Aug 25, 2023 that may be closed by this pull request
Validation of documents and protocols #397
Closed
@s-l-teichmann s-l-teichmann changed the title Downloader: Add structured logging, fails storing Downloader: Add structured logging, fails storing and statistics Aug 25, 2023
@s-l-teichmann s-l-teichmann marked this pull request as ready for review August 25, 2023 17:09
ThomasJunk
ThomasJunk approved these changes Aug 28, 2023
View reviewed changes
Copy link
Contributor

@ThomasJunk ThomasJunk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and works.

bernhardreiter
bernhardreiter approved these changes Aug 28, 2023
View reviewed changes
Copy link
Member

@bernhardreiter bernhardreiter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
(found some minor things to be addressed later)

@bernhardreiter bernhardreiter merged commit 5459f10 into main Aug 28, 2023
3 checks passed
@bernhardreiter bernhardreiter deleted the downloader-logging branch August 28, 2023 13:03
@bernhardreiter bernhardreiter mentioned this pull request Aug 28, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bernhardreiter bernhardreiter bernhardreiter approved these changes

@ThomasJunk ThomasJunk ThomasJunk approved these changes

@JanHoefelmeyer JanHoefelmeyer Awaiting requested review from JanHoefelmeyer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Validation of documents and protocols
3 participants
@s-l-teichmann @ThomasJunk @bernhardreiter