Compare scripts via object_id #1036
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
API docs are being generated and will be shortly available at: https://godot-rust.github.io/docs/gdext/pr-1036 |
Bromeon
added
quality-of-life
Bromeon
reviewed
Feb 5, 2025
Comment on lines
+363
to
+367
| if object_script_variant | ||
| .object_id() | ||
| .map(|instance_id| instance_id != script.instance_id()) | ||
| .unwrap_or(true) | ||
| { |
There was a problem hiding this comment.
It looks like this changes behavior:
previous condition was a != b
so if a is null, the overall condition is only true if b is not null.
now it's a.map(|a| a != b).unwrap_or(true)
meaning if a is null, the whole condition is always true.
There was a problem hiding this comment.
btw, this could be Option::map_or(), no?
| @@ -371,6 +373,8 @@ where | |||
| }; | |||
|
|
|||
| let get_instance_fn = sys::interface_fn!(object_get_script_instance); | |||
|
|
|||
| // SAFETY: object and language are alive and their sys pointers are valid | |||
There was a problem hiding this comment.
Suggested change
| // SAFETY: object and language are alive and their sys pointers are valid | |
| // SAFETY: object and language are alive and their sys pointers are valid. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up for #1013 that adds
SAFETYcomment to unsafe block and usesobject_id()for script object comparison.