unpin trio version #46
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trio was pinned to 0.24.0 due to some instabilities in 0.25.0 version in CI runs. Right now the newest version is 0.28.0, so it might already be fixed. Additionally new trio version is required to run with Python 3.13, which is the latest stable release. Signed-off-by: Marcin Niestroj <[email protected]>
sam-golioth
reviewed
Jan 10, 2025
| @@ -26,7 +26,7 @@ dependencies = [ | |||
| "imgtool", | |||
| "pyyaml", | |||
| "rich", | |||
| "trio==0.24.0", | |||
| "trio", | |||
There was a problem hiding this comment.
Should we do >=0.26.0 or something similar? I'm not sure we ever root-caused the original issue other than tracking it to this release. Have you tested CI with a newer trio version?
There was a problem hiding this comment.
I have not tracked it, so I am not sure whether or when it was fixed. Commit message eadfc15 says about "some CI issue", so I'm not sure how and when it might reproduce.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
trio was pinned to 0.24.0 due to some instabilities in 0.25.0 version in CI
runs. Right now the newest version is 0.28.0, so it might already be fixed.
Additionally new trio version is required to run with Python 3.13, which is the
latest stable release.