Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unpin trio version #46

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

unpin trio version #46

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ dependencies = [
"imgtool",
"pyyaml",
"rich",
"trio==0.24.0",
"trio",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we do >=0.26.0 or something similar? I'm not sure we ever root-caused the original issue other than tracking it to this release. Have you tested CI with a newer trio version?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have not tracked it, so I am not sure whether or when it was fixed. Commit message eadfc15 says about "some CI issue", so I'm not sure how and when it might reproduce.

"trio-websocket",
]

Expand Down
Loading