Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate all tests to Truth & use assertThrows #2687

Merged
merged 8 commits into from
Jun 7, 2024

Conversation

Marcono1234
Copy link
Collaborator

Purpose

Migrate all tests to Truth & use assertThrows

Description

  • Migrates all remaining tests to use Truth instead of JUnit for assertions
  • Refactors all test code from try { ...; fail(); } catch (expected) { } to assertThrows
  • Improves some tests

Checklist

  • New code follows the Google Java Style Guide
    This is automatically checked by mvn verify, but can also be checked on its own using mvn spotless:check.
    Style violations can be fixed using mvn spotless:apply; this can be done in a separate commit to verify that it did not cause undesired changes.
  • If necessary, new public API validates arguments, for example rejects null
  • New public API has Javadoc
    • Javadoc uses @since $next-version$
      ($next-version$ is a special placeholder which is automatically replaced during release)
  • If necessary, new unit tests have been added
    • Assertions in unit tests use Truth, see existing tests
    • No JUnit 3 features are used (such as extending class TestCase)
    • If this pull request fixes a bug, a new test was added for a situation which failed previously and is now fixed
  • mvn clean verify javadoc:jar passes without errors

Copy link
Member

@eamonnmcmanus eamonnmcmanus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fantastic! Thanks for the many small improvements throughout, beyond just the mechanical transformation into assertThat and assertThrows.

Just a couple of very minor things.

Because there is only `Gson.toJson(Object)` (and no primitive specific
overloads) the tests were previously testing the adapter for the boxed
object, e.g. Double, twice.
@Marcono1234 Marcono1234 marked this pull request as draft June 7, 2024 19:25
@Marcono1234
Copy link
Collaborator Author

Sorry for the delay; I have added a few more test improvements. This pull request should now be ready.

@Marcono1234 Marcono1234 marked this pull request as ready for review June 7, 2024 22:04
This works because unlike the main sources the tests are compiled with Java 11.
@eamonnmcmanus eamonnmcmanus merged commit 99cc4cb into google:main Jun 7, 2024
11 checks passed
@Marcono1234 Marcono1234 deleted the marcono1234/test-refactoring branch June 7, 2024 23:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants