Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate all tests to Truth & use assertThrows #2687

Merged
merged 8 commits into from
Jun 7, 2024
Merged

Migrate all tests to Truth & use assertThrows #2687

merged 8 commits into from
Jun 7, 2024

Commits on May 26, 2024

  1. Use assertThrows for expected exceptions in tests

    @Marcono1234
    Marcono1234 committed May 26, 2024
    Configuration menu
    Copy the full SHA
    88632a9 View commit details
    Browse the repository at this point in the history

  2. Use Truth for unit tests in proto and extras module

    @Marcono1234
    Marcono1234 committed May 26, 2024
    Configuration menu
    Copy the full SHA
    20566ed View commit details
    Browse the repository at this point in the history

  3. Perform assertions on some currently unused test variables

    @Marcono1234
    Marcono1234 committed May 26, 2024
    Configuration menu
    Copy the full SHA
    7bbea12 View commit details
    Browse the repository at this point in the history

  4. Improve tests

    @Marcono1234
    Marcono1234 committed May 26, 2024
    Configuration menu
    Copy the full SHA
    f01d394 View commit details
    Browse the repository at this point in the history

Commits on Jun 7, 2024

  1. Merge branch 'main' into marcono1234/test-refactoring

    @Marcono1234
    Marcono1234 committed Jun 7, 2024
    Configuration menu
    Copy the full SHA
    3a88a3d View commit details
    Browse the repository at this point in the history

  2. Improve non-finite floating point tests 

    Because there is only `Gson.toJson(Object)` (and no primitive specific
overloads) the tests were previously testing the adapter for the boxed
object, e.g. Double, twice.
    @Marcono1234
    Marcono1234 committed Jun 7, 2024
    Configuration menu
    Copy the full SHA
    512cea3 View commit details
    Browse the repository at this point in the history

  3. Improve tests

    @Marcono1234
    Marcono1234 committed Jun 7, 2024
    Configuration menu
    Copy the full SHA
    9f8620d View commit details
    Browse the repository at this point in the history

  4. Remove explicit type arguments from tests where they can be inferred 

    This works because unlike the main sources the tests are compiled with Java 11.
    @Marcono1234
    Marcono1234 committed Jun 7, 2024
    Configuration menu
    Copy the full SHA
    5ef8a22 View commit details
    Browse the repository at this point in the history