Fixup on construction active element algorithm #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neuodev
reviewed
Sep 25, 2023
|
fg |
jaytaph
force-pushed
the
parser
branch
2 times, most recently
from
279c2c8
to
2cc9a30
Compare
|
I've updated the parser so it's in line with the main branch. I think i'm going to get rid of all the test-code so the current state as-is, is mergeable, even though not completely functioning. This way I think more people can take a look at the code and try to get it right. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tries to get the active element reconstruction running properly. It still fails horribly on the
<a><p>X<a>Y</a>Z</p></a>test from test1.dat in the html5lib-tests repo. There are still some function implementations missing in the parser (mod.rs).