Fix textureSampleCompareLevel sample point code. #4194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is bug that surfaced only if the test failed. The issue is that textureSampleLevel, which it uses when textureSampleCompareLevel fails, needs the level parameter to be i32/u32 when the texture is a depth texture. Again, this only happens when we already know the test failed so this doesn't affect pass/fail. It only affects getting the sample points.
shrekshao
approved these changes
Feb 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is bug that surfaced only if the test failed. The issue is that textureSampleLevel, which it uses when textureSampleCompareLevel fails, needs the level parameter to be i32/u32 when the texture is a depth texture.
Again, this only happens when we already know the test failed so this doesn't affect pass/fail. It only affects getting the sample points.