Improve dataframe's upload accessibility #10478
Merged
+34
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🪼 branch checks and previews
Install Gradio from this PR pip install https://gradio-pypi-previews.s3.amazonaws.com/52994d05f2f8ec0aa359ff85dd85378dec4bdae3/gradio-5.14.0-py3-none-any.whlInstall Gradio Python Client from this PR pip install "gradio-client @ git+https://github.com/gradio-app/gradio@52994d05f2f8ec0aa359ff85dd85378dec4bdae3#subdirectory=client/python"Install Gradio JS Client from this PR npm install https://gradio-npm-previews.s3.amazonaws.com/52994d05f2f8ec0aa359ff85dd85378dec4bdae3/gradio-client-1.10.0.tgzUse Lite from this PR <script type="module" src="https://gradio-lite-previews.s3.amazonaws.com/52994d05f2f8ec0aa359ff85dd85378dec4bdae3/dist/lite.js""></script> |
🦄 change detectedThis Pull Request includes changes to the following packages.
With the following changelog entry.
Maintainers or the PR author can modify the PR title to modify this entry.
|
hannahblair
changed the title
dawoodkhan82
reviewed
Feb 3, 2025
js/dataframe/shared/Table.svelte
Outdated
| @@ -936,6 +936,7 @@ | |||
| {root} | |||
| on:load={(e) => blob_to_string(data_uri_to_blob(e.detail.data))} | |||
| bind:dragging | |||
| aria_label="Drop CSV or TSV files here to import data into dataframe" | |||
There was a problem hiding this comment.
Should we use i18n("dataframe.drop_to_upload") here
There was a problem hiding this comment.
ah yes we should
|
thanks for reviewing @dawoodkhan82! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In the dataframe's DOM, the Upload component is a big button encapsulating the table, which is pretty confusing from a screen reader's POV. I've added some context which should improve the semantics of this.
Closes: #(issue)
🎯 PRs Should Target Issues
Before your create a PR, please check to see if there is an existing issue for this change. If not, please create an issue before you create this PR, unless the fix is very small.
Not adhering to this guideline will result in the PR being closed.
Testing and Formatting Your Code
PRs will only be merged if tests pass on CI. We recommend at least running the backend tests locally, please set up your Gradio environment locally and run the backed tests:
bash scripts/run_backend_tests.shPlease run these bash scripts to automatically format your code:
bash scripts/format_backend.sh, and (if you made any changes to non-Python files)bash scripts/format_frontend.sh