-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve dataframe's upload accessibility #10478
Merged
+34
−12
Merged
Changes from 6 commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
6dbacd8
add aria-labels to dataframe upload
hannahblair 9ab3a5c
add changeset
gradio-pr-bot a1d54a2
Merge branch 'main' into df-a11y-upload
hannahblair b0e9d9e
tweaks
hannahblair 03dba22
add changeset
gradio-pr-bot 48e4388
Merge branch 'main' into df-a11y-upload
dawoodkhan82 6f9af7f
add aria-labels for other components
hannahblair 9402d92
add changeset
gradio-pr-bot 3b8ef80
Merge branch 'main' into df-a11y-upload
hannahblair bc3db44
revert removal
hannahblair 274ba78
Merge branch 'df-a11y-upload' of github.com:gradio-app/gradio into df…
hannahblair 6c3f613
Merge branch 'main' into df-a11y-upload
hannahblair 2851bab
fix test
hannahblair 0b0b625
Merge branch 'df-a11y-upload' of github.com:gradio-app/gradio into df…
hannahblair 52994d0
hopefully fix test
hannahblair File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
--- | ||
"@gradio/core": minor | ||
"@gradio/dataframe": minor | ||
"@gradio/upload": minor | ||
"gradio": minor | ||
--- | ||
|
||
feat:Improve dataframe's upload accessibility |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we use
i18n("dataframe.drop_to_upload")
hereThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah yes we should