Add python 3 support #220
Add python 3 support #220
Conversation
…d install bs3 under py3
|
When we can expect that this will be merged? |
|
+1 for merging |
|
+1 |
|
ping @grangier |
|
Is there any problem with this PR? Can we help somehow or you are just ignoring it? |
|
@grangier +1 |
See https://github.com/vetal4444/python-goose/tree/python_3 grangier#220 Conflicts: goose/text.py
| @@ -2,5 +2,6 @@ Pillow | |||
| lxml | |||
| cssselect | |||
| jieba | |||
| beautifulsoup | |||
| beautifulsoup # Only on python2 | |||
There was a problem hiding this comment.
so your code will not work in python 3?
| @@ -2,5 +2,6 @@ Pillow | |||
| lxml | |||
| cssselect | |||
| jieba | |||
| beautifulsoup | |||
| beautifulsoup # Only on python2 | |||
There was a problem hiding this comment.
This is not working in python 3.5.4 as it does not support beautifulsoup. Even after changing the requires.txt with beautidulsoup4 the install didnt work. Attached error file
error_goose_extract.txt
|
Waiting for so long!!! |
|
@gaussic You actually wait for it? This project is 3 years dead. There is plethora of better solutions already, such as https://github.com/goose3/goose3 or https://github.com/codelucas/newspaper |
|
Thanks but newspaper doesn't work that well AFAIK |
|
Why are people still using beautiful soup in 2018? |
|
@hnykda Great, thanks man. By the way, @amirouche I'm still using BeautifulSoup 4 and it's easy to use. |
If you run goose under python bs3 parser will not be able to use.