Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add python 3 support #220

Open
wants to merge 21 commits into
base: develop
Choose a base branch
from
Open

Add python 3 support #220

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
8e2f875
Merge branch 'release/v1.0.19'
Jun 29, 2014
93e8239
Merge branch 'release/1.0.20'
Jul 14, 2014
a275c45
Merge branch 'master' of github.com:grangier/python-goose
Jul 14, 2014
fba20fd
Merge branch 'release/1.0.21'
Sep 14, 2014
f5dc260
Merge branch 'release/1.0.22'
Sep 14, 2014
3b058f9
Merge remote-tracking branch 'origin/master' into develop
pistolero Jan 6, 2015
4478e69
Merge remote-tracking branch 'upstream/develop' into develop
vetal4444 Apr 8, 2015
94b1a20
Add python3 support
vetal4444 Apr 8, 2015
6d91565
Update requirements
vetal4444 Apr 8, 2015
79a12dd
Add python3 to CLASSIFIERS
vetal4444 Apr 9, 2015
76af358
Optimize imports
vetal4444 Apr 9, 2015
f44c2af
Restore python 2.6 support
vetal4444 Apr 9, 2015
2e18083
Try to fix tests in python 2.6
vetal4444 Apr 9, 2015
b7884f1
Fix smart_str
vetal4444 Apr 15, 2015
9028761
Fix ValueError if we get document with set encoding. Add test case fo…
vetal4444 Apr 15, 2015
74743ab
Add py 3.4 to travis.yml
vetal4444 Apr 15, 2015
5fbc788
Remove install from requirements file in travis.yml as no way to avoi…
vetal4444 Apr 15, 2015
1d02932
Close image file after use
vetal4444 Apr 15, 2015
9091e38
Fix tests
vetal4444 Apr 15, 2015
8fa55b4
Fix encoding detection
vetal4444 Apr 16, 2015
1ef277b
Fix test runner under py3
vetal4444 Apr 16, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,5 +2,6 @@ Pillow
lxml
cssselect
jieba
beautifulsoup
beautifulsoup # Only on python2
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so your code will not work in python 3?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not working in python 3.5.4 as it does not support beautifulsoup. Even after changing the requires.txt with beautidulsoup4 the install didnt work. Attached error file
error_goose_extract.txt

nltk
six
9 changes: 8 additions & 1 deletion setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,8 @@
"""

import os
import sys

from setuptools import setup, find_packages
from imp import load_source

Expand Down Expand Up @@ -53,6 +55,11 @@
except Exception:
long_description = description

requirements = ['Pillow', 'lxml', 'cssselect', 'jieba', 'nltk', 'six']
if sys.version_info.major == 2:
requirements.append('beautifulsoup')


setup(name='goose-extractor',
version=version.__version__,
description=description,
Expand All @@ -66,6 +73,6 @@
packages=find_packages(),
include_package_data=True,
zip_safe=False,
install_requires=['Pillow', 'lxml', 'cssselect', 'jieba', 'nltk'],
install_requires=requirements,
test_suite="tests"
)