Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set up dedicated logger to retain CLI stdout #246

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from

Merge branch 'main' of github.com:great-expectations/cloud into m/set…

0b8a7aa
Select commit
Loading
Failed to load commit list.
Draft

set up dedicated logger to retain CLI stdout #246

Merge branch 'main' of github.com:great-expectations/cloud into m/set…
0b8a7aa
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed May 3, 2024 in 0s

66.18% (-18.54%) compared to fdfe9b4

View this Pull Request on Codecov

66.18% (-18.54%) compared to fdfe9b4

Details

Codecov Report

Attention: Patch coverage is 75.00000% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 66.18%. Comparing base (fdfe9b4) to head (0b8a7aa).

Files Patch % Lines
great_expectations_cloud/agent/agent.py 85.00% 3 Missing ⚠️
great_expectations_cloud/agent/cli.py 0.00% 2 Missing ⚠️
great_expectations_cloud/agent/run.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main     #246       +/-   ##
===========================================
- Coverage   84.71%   66.18%   -18.54%     
===========================================
  Files          25       25               
  Lines         962      961        -1     
===========================================
- Hits          815      636      -179     
- Misses        147      325      +178     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.