Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use openvasd #2169

Merged
merged 3 commits into from
Jun 11, 2024
Merged

use openvasd #2169

merged 3 commits into from
Jun 11, 2024

Conversation

nichtsfrei
Copy link
Member

  • Adds toggle OPENVASD to enable or disable openvasd specific code
  • Adds possibility to add cmake flags to a container build

Copy link

Conventional Commits Report

😢 No conventional commits found.

👉 Learn more about the conventional commits usage at Greenbone.

@nichtsfrei nichtsfrei force-pushed the use-openvasd branch 4 times, most recently from b943f4a to 59eaf75 Compare April 17, 2024 11:34
@a-h-abdelsalam
Copy link
Contributor

Looks good and adding OpenVASD output to --version is good enough.

@nichtsfrei Is there anything else from your side to add to this PR or is it ready ?

To enable openvasd functionality add `-DOPENVASD=1` while creating the
build definition.

As an example:
```
cmake -DCMAKE_BUILD_TYPE=Release \
	-DCMAKE_EXPORT_COMPILE_COMMANDS=1 \
	-DOPENVASD=1 \
	-Bbuild .

```
@nichtsfrei nichtsfrei marked this pull request as ready for review June 11, 2024 14:19
@nichtsfrei nichtsfrei requested review from a team as code owners June 11, 2024 14:19
@a-h-abdelsalam a-h-abdelsalam merged commit 274e326 into main Jun 11, 2024
11 checks passed
@a-h-abdelsalam a-h-abdelsalam deleted the use-openvasd branch June 11, 2024 15:00
@jjnicola
Copy link
Member

Jira SC-1054

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants