Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add container level to config tool #1728

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

cemms1
Copy link
Contributor

@cemms1 cemms1 commented Nov 15, 2024

What's changed?

Uses latest release of facia-scala-client which adds SecondaryLevel as a possible metadata value.

The previous implementation had both Primary and Secondary as metadata options but since all containers are considered "primary" unless specified as "secondary", we can reduce this to just one option. This also includes the word "level" as part of the metadata to better communicate what this does and how it is distinct from a palette option.

This PR also applies special styling to secondary level containers at the fronts tool level by reducing the size of the container title and using sans font family, much like the way the platforms will treat secondary level containers.

Implementation notes

Screenshots

Before After
Config tool before2 after2
Fronts tool before after

Checklist

General

  • 🤖 Relevant tests added
  • ✅ CI checks / tests run locally
  • 🔍 Checked on CODE

Client

  • 🚫 No obvious console errors on the client (i.e. React dev mode errors)
  • 🎛️ No regressions with existing user interactions (i.e. all existing buttons, inputs etc. work)
  • 📷 Screenshots / GIFs of relevant UI changes included

@cemms1 cemms1 self-assigned this Nov 15, 2024
@cemms1 cemms1 force-pushed the fairground/add-container-level branch from 4e0c6be to 7b141a8 Compare November 18, 2024 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant