Add third parameter with response to trace and allow it to be asynchronous #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diogob
force-pushed
the
async-trace-with-response
branch
from
5fdd481
to
9441863
Compare
…ype make it easier to write callbacks without having to check optional values. It is backwards compatible,
…s not necessarly what fetch receives. The same applies to the second parameter.
diogob
force-pushed
the
async-trace-with-response
branch
from
0a8761c
to
38a9d64
Compare
gustavoguichard
approved these changes
Aug 2, 2024
src/types.ts
Outdated
| trace?: ( | ||
| fullUrl: string | URL, | ||
| init: EnhancedRequestInit, | ||
| response: Awaited<ReturnType<typeof fetch>>, |
There was a problem hiding this comment.
Couldn't you use TypedResponse type here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.