Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add third parameter with response to trace and allow it to be asynchronous #53

Merged
merged 4 commits into from
Aug 2, 2024
Merged

Add third parameter with response to trace and allow it to be asynchronous #53

merged 4 commits into from
Aug 2, 2024

Commits on Aug 1, 2024

  1. Add third parameter with response to trace and allow it to be asynchr… 

    …onous
    @diogob
    diogob committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    9441863 View commit details
    Browse the repository at this point in the history

  2. These parameters are always passed, so having them mandatory in our t… 

    …ype make it easier to write callbacks without having to check optional values. It is backwards compatible,
    @diogob
    diogob committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    499e6cf View commit details
    Browse the repository at this point in the history

  3. We need a more precise type for the fullURL since the value we pass i… 

    …s not necessarly what fetch receives. The same applies to the second parameter.
    @diogob
    diogob committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    38a9d64 View commit details
    Browse the repository at this point in the history

Commits on Aug 2, 2024

  1. Use a TypedResponse for the trace function

    @diogob
    diogob committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    4cacee3 View commit details
    Browse the repository at this point in the history