-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(#162): moved repo type #164
base: master
Are you sure you want to change the base?
Conversation
# Conflicts: # server/Cargo.toml
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #164 +/- ##
=======================================
Coverage 83.15% 83.15%
=======================================
Files 16 16
Lines 285 285
=======================================
Hits 237 237
Misses 48 48 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -0,0 +1,5 @@ | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@l3r8yJ this file should be not pushed to the branch. Let's add it to the .gitignore
# OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE | ||
# SOFTWARE. | ||
[package] | ||
name = "types" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@l3r8yJ it's better to name package fakehub-types
, instead of types
. Thus we will be able to publish this package. WDYT?
# SOFTWARE. | ||
[package] | ||
name = "types" | ||
version = "0.1.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@l3r8yJ version should be freezed (0.0.0
), I believe
*/ | ||
/// The types. | ||
pub mod types; | ||
// @todo #162:25min Remove dumb documentation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@l3r8yJ I think these docs is set by default for lib.rs
and main.rs
files, correct me if I'm wrong
The types. | ||
*/ | ||
/// The types. | ||
pub mod types; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -22,3 +22,5 @@ github-mirror/.gitignore | |||
github-mirror/git_push.sh | |||
github-mirror/README.md | |||
github-mirror/.openapi-generator-ignore | |||
github-mirror/**/src |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@l3r8yJ we can't ignore github-mirror/src
because, when we release fakehub, we package and push github-mirror to crates too
@@ -0,0 +1,14 @@ | |||
[package] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@l3r8yJ this should file will be autogenerated, we don't need to keep it in the repo
@@ -38,7 +38,8 @@ path = "src/lib.rs" | |||
workspace = true | |||
|
|||
[dependencies] | |||
openapi = { path = "../github-mirror", version = "1.1.4" } | |||
openapi = { path = "../github-mirror" } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
||
/// GitHub. | ||
#[derive(Clone)] | ||
pub struct GitHub { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@l3r8yJ we have GitHub
in server/objects/github.rs
. We should somehow resolve ambiguity with naming here
@h1alexbel this PR still in WIP status, miss clicked on review button |
the POC
PR-Codex overview
This PR introduces a restructuring of the codebase, primarily focusing on the organization of modules and the addition of new dependencies, including the
kill-port
package. It also refactors therepo
module intorepo_ops
, enhancing the functionality related to repository operations.Detailed summary
kill-port
dependency inpackage.json
andpackage-lock.json
.Cargo.toml
to include a newtypes
module.repo
module torepo_ops
inserver/src/objects/mod.rs
.RepoOperations
trait inrepo_ops.rs
for better repo management.Repo
struct intypes/src/types/repo.rs
.User
struct intypes/src/types/user.rs
to includerepos
.GitHub
struct intypes/src/types/github.rs
for GitHub representation.