Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backend: ReputationHelper "Rewrite" #3207

Open
wants to merge 7 commits into
base: beta
Choose a base branch
from

Conversation

j10a1n15
Copy link
Contributor

What

Rewrote ReputationHelper to use renderables, changed the factionType getter to use TabwidgetUpdateEvent.
Removed clickType in favor of clickTypeEnum, renamed the clickTypeEnum variable to just clickType

Changelog Technical Details

  • Rewrote ReputationHelper to use Renderables & TabWidgetUpdateEvent. - j10a1n15
  • Removed deprecated clickType field. - j10a1n15

@github-actions github-actions bot added the Backend A backend pull request that will be merged soon label Jan 11, 2025
Signed-off-by: J10a1n15 <[email protected]>
Signed-off-by: J10a1n15 <[email protected]>
@github-actions github-actions bot added the Detekt Has detekt problem label Jan 11, 2025
Copy link

One or more Detekt Failures were detected:

Signed-off-by: J10a1n15 <[email protected]>
Signed-off-by: J10a1n15 <[email protected]>
@github-actions github-actions bot removed the Detekt Has detekt problem label Jan 11, 2025
Copy link
Contributor

@Thunderblade73 Thunderblade73 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes seem to be fine.
Only thing I want to note is that the Extension functions addQuests, addKuudra, addBosses can get annoying since the come up as suggestions for any MutableList. Not sure how to do it better though.

@j10a1n15
Copy link
Contributor Author

j10a1n15 commented Jan 11, 2025

Only thing I want to note is that the Extension functions addQuests, addKuudra, addBosses can get annoying since the come up as suggestions for any MutableList.

I dont think so since they are in classes, not objects

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backend A backend pull request that will be merged soon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants