-
-
Notifications
You must be signed in to change notification settings - Fork 213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backend: ReputationHelper "Rewrite" #3207
base: beta
Are you sure you want to change the base?
Backend: ReputationHelper "Rewrite" #3207
Conversation
Signed-off-by: J10a1n15 <[email protected]>
Signed-off-by: J10a1n15 <[email protected]>
Signed-off-by: J10a1n15 <[email protected]>
Signed-off-by: J10a1n15 <[email protected]>
...n/java/at/hannibal2/skyhanni/features/nether/reputationhelper/CrimsonIsleReputationHelper.kt
Outdated
Show resolved
Hide resolved
Signed-off-by: J10a1n15 <[email protected]>
One or more Detekt Failures were detected:
|
Signed-off-by: J10a1n15 <[email protected]>
Signed-off-by: J10a1n15 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes seem to be fine.
Only thing I want to note is that the Extension functions addQuests, addKuudra, addBosses can get annoying since the come up as suggestions for any MutableList. Not sure how to do it better though.
I dont think so since they are in classes, not objects |
What
Rewrote ReputationHelper to use renderables, changed the factionType getter to use TabwidgetUpdateEvent.
Removed clickType in favor of clickTypeEnum, renamed the clickTypeEnum variable to just clickType
Changelog Technical Details