-
-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backend: DelayedRun sync #746
Conversation
This pull request has conflicts with the base branch "beta". Please resolve those so we can test out your changes. |
# Conflicts: # src/main/java/at/hannibal2/skyhanni/utils/LorenzUtils.kt
Conflicts have been resolved! 🎉 |
This pull request has conflicts with the base branch "beta". Please resolve those so we can test out your changes. |
Conflicts have been resolved! 🎉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The logic looks fancy, thanks <3
Not sure if im missing something but one small thing here looks misleading or wrong to me
Since both suggestion are for one and the same issue: |
The idea behind "run in next tick" for me was not a "provide at least 50ms delay" but rather "run in the next tick in the main thread". Now only one question remains to me: should we rename the function runNextTick to something else? |
The name is fine. Also documented the behavior. |
Found a better sync bug fix.