build: support s390x architecture for linux (ent) #18069
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shoenig
reviewed
Jul 26, 2023
| @@ -53,6 +53,7 @@ ALL_TARGETS = linux_386 \ | |||
| linux_amd64 \ | |||
| linux_arm \ | |||
| linux_arm64 \ | |||
| linux_s390x \ | |||
There was a problem hiding this comment.
wouldn't adding this line cause s390x builds to happen in the oss pipeline?
There was a problem hiding this comment.
no, this only lists linux_s390x as one of the potential make pkg/ targets. You can build an s390x binary manually this way, but the oss build pipeline depends on the build workflow. (attached a screenshot of a running build pipeline for this branch)
shoenig
approved these changes
Jul 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makefile changes required for supporting s390x builds and a corresponding changelog entry.
Enterprise PR: https://github.com/hashicorp/nomad-enterprise/pull/1202
Resolves #18068