Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: support s390x architecture for linux (ent) #18069

Merged
merged 3 commits into from
Jul 26, 2023
Merged

build: support s390x architecture for linux (ent) #18069

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
63c049a
build: support s390x architecture for linux (ent)
pkazmierczak Jul 26, 2023
3384080
changelog entry
pkazmierczak Jul 26, 2023
3b0dcc3
changelog format correction
pkazmierczak Jul 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .changelog/18069.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
```release-note:improvement
build (Enterprise): Support building s390x binaries.
```
1 change: 1 addition & 0 deletions GNUmakefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,7 @@ ALL_TARGETS = linux_386 \
linux_amd64 \
linux_arm \
linux_arm64 \
linux_s390x \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wouldn't adding this line cause s390x builds to happen in the oss pipeline?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no, this only lists linux_s390x as one of the potential make pkg/ targets. You can build an s390x binary manually this way, but the oss build pipeline depends on the build workflow. (attached a screenshot of a running build pipeline for this branch)
Screenshot 2023-07-26 at 16 52 03

windows_386 \
windows_amd64
endif
Expand Down
Loading