-
Notifications
You must be signed in to change notification settings - Fork 704
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
project planning: fix #10686 regression #10771
Conversation
cfe7ffd
to
dbdf306
Compare
It's not clear to me how to add a test to this. I've tried adding a check for directory-does-not-exist for the scripts run in @ffaf1 I've run out of time, but perhaps you could try to write a test if you'd like. |
dbdf306
to
e17761f
Compare
I tested manually that the patch fixes my reproducer from #10686. Good enough for me, thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense to me. Thanks!
I don't know why the readthedocs check failed @ulysses4ever |
@alt-romes it started recently and no one knows why. The branch needs an update to trigger rebuild as we can't trigger RTD rebuild manually, sadly. Also, "no rebase" labels are reserved for special cases. Normally, you're expected to use "merge me". |
@mergify rebase |
We previously only fetched the compiler in `instantiateProjectConfigSkeletonFetchingCompiler` if `null (toListOf traverseCondTreeV skel)` was false. c89ab54 changed this to always configure the compiler, such that it could be later re-used when determining whether jsem was supported to clone git submodules concurrently. This patch allows for the JobControl concurrency mechanism to be controlled without a compiler (which assumes -jsem is not supported), and restores the behaviour of not always configuring the compiler. Fixes haskell#10686
✅ Branch has been successfully rebased |
e17761f
to
b817cb7
Compare
Phew, readthedocs passes fine now. Thank you whomever fixed it. :) |
We previously only fetched the compiler in
instantiateProjectConfigSkeletonFetchingCompiler
ifnull (toListOf traverseCondTreeV skel)
was false.c89ab54 changed this to always configure the compiler, such that it could be later re-used when determining whether jsem was supported to clone git submodules concurrently.
This patch allows for the JobControl concurrency mechanism to be controlled without a compiler (which assumes -jsem is not supported), and restores the behaviour of not always configuring the compiler.
Fixes #10686
Please read Github PR Conventions and then fill in one of these two templates.
Template Α: This PR modifies behaviour or interface
Include the following checklist in your PR:
significance: significant
in the changelog file.