Fixing reproducibility error introduced by 24-CNB vs 24-Heroku #332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The 24-Heroku stack adds a user like `u12345` and a `dyno` user, both with HOME of /app. The 24-CNB stack breaks this convention by introducing a `heroku` user with a `HOME` of `/home/heroku`. This prevents packages such as [fontconfig which expects .fonts to be available in HOME](https://www.freedesktop.org/software/fontconfig/fontconfig-user.html). In non-CNB builds, `HOME` and `/app` are the same, so a `/app/.fonts/this.ttf` is available as expected at runtime. In CNB builds, these are different, so the same font would be at `/app/.fonts/this.ttf`, while the runtime path searched would be `/home/heroku/.fonts`. This fix has been thoroughly tested and helps Heroku customers achieve better reproducibility and alignment with open standards.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The 24-Heroku stack adds a user like
u12345and adynouser, both withHOMEof/app. The 24-CNB stack breaks this convention by introducing aherokuuser with aHOMEof/home/heroku. This prevents packages such as fontconfig which expects .fonts to be available in HOME.In non-CNB builds,
HOMEand/appare the same, so a/app/.fonts/this.ttfis available as expected at runtime.In CNB builds, these are different, so the same font would be at
/app/.fonts/this.ttf, while the runtime path searched would be/home/heroku/.fonts.This fix has been thoroughly tested and helps Heroku customers achieve better reproducibility and alignment with open standards.