Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing reproducibility error introduced by 24-CNB vs 24-Heroku #332

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fixing reproducibility error introduced by 24-CNB vs 24-Heroku #332

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3bed84a
Fixing reproducibility error introduced by 24-CNB vs 24-Heroku
usiegj00 Nov 12, 2024
5f6c338
Update Dockerfile
usiegj00 Nov 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions heroku-24-build/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,3 +14,7 @@ ENV CNB_GROUP_ID=1000
# Stack IDs are deprecated, but we still set this for backwards compatibility:
# https://github.com/buildpacks/spec/blob/platform/0.13/platform.md#iobuildpacksstack-labels
ENV CNB_STACK_ID="heroku-24"

# Match HOME operation done in [heroku-22](https://github.com/usiegj00/base-images/blob/3bed84a6cf88bc6535b1ef18acbc454f88c854d8/heroku-22-cnb/Dockerfile#L17).
# This is related to [the user HOME issue exposed here](https://github.com/heroku/base-images/pull/332).
ENV HOME=/workspace
4 changes: 2 additions & 2 deletions heroku-24/setup.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,8 +154,8 @@ test "$(file --brief /etc/ssl/certs/java/cacerts)" = "Java KeyStore"
# that we have to remove before creating our own (`userdel` will remove the group too).
userdel ubuntu --remove

groupadd heroku --gid 1000
useradd heroku --uid 1000 --gid 1000 --shell /bin/bash --create-home
groupadd dyno --gid 1000
useradd dyno --uid 1000 --gid 1000 --shell /bin/bash --home /app --create-home

rm -rf /root/*
rm -rf /tmp/*
Expand Down