Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(load_plugins): ignore hexo-theme-[config.theme] #4111

Merged
merged 1 commit into from
Mar 30, 2020
Merged

feat(load_plugins): ignore hexo-theme-[config.theme] #4111

merged 1 commit into from
Mar 30, 2020

Conversation

SukkaW
Copy link
Member

@SukkaW SukkaW commented Jan 31, 2020

What does it do?

The part of #3890

#3890 (comment)

How to test

git clone -b feat-ignore-theme-in-plugin https://github.com/sukkaw/hexo.git
cd hexo
npm install
npm test

Screenshots

Pull request tasks

  • Add test cases for the changes.
  • Passed the CI test.

@SukkaW SukkaW force-pushed the feat-ignore-theme-in-plugin branch from 86f32df to 0f37309 Compare January 31, 2020 10:26
@coveralls
Copy link

Coverage Status

Coverage increased (+0.003%) to 97.704% when pulling 0f37309 on SukkaW:feat-ignore-theme-in-plugin into 667d9a0 on hexojs:master.

@coveralls
Copy link

coveralls commented Jan 31, 2020 •
edited
Loading

Coverage Status

Coverage increased (+0.003%) to 97.704% when pulling 4be9a99 on SukkaW:feat-ignore-theme-in-plugin into 667d9a0 on hexojs:master.

@SukkaW SukkaW force-pushed the feat-ignore-theme-in-plugin branch from 0f37309 to 4be9a99 Compare January 31, 2020 12:58
yoshinorin
yoshinorin requested changes Feb 15, 2020
View reviewed changes
lib/hexo/load_plugins.js Outdated Show resolved Hide resolved
@SukkaW SukkaW requested review from yoshinorin and a team February 23, 2020 07:14
curbengh
curbengh reviewed Feb 24, 2020
View reviewed changes
test/scripts/hexo/load_plugins.js Outdated
@@ -128,6 +128,23 @@ describe('Load plugins', () => {
});
});

it('ignore plugin whose name is "hexo-theme-[hexo.config.theme]"', () => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggest new tests to use async.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change to async and rebased.

yoshinorin
yoshinorin approved these changes Mar 30, 2020
View reviewed changes
Copy link
Member

@yoshinorin yoshinorin left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

BTW, we should create the plugins option document. I can't find any document of it.

@yoshinorin
Copy link
Member

yoshinorin commented Mar 30, 2020 •
edited
Loading

PS

The Appveyor build was failed. But, my local PC (Windows node 13.0.1) test was passed.
I think no-problem of this error.

@SukkaW SukkaW merged commit c7b72e0 into hexojs:master Mar 30, 2020
@SukkaW
Copy link
Member Author

SukkaW commented Mar 30, 2020

The Appveyor build was failed. But, my local PC (Windows node 13.0.1) test was passed.

I believe the issue is related with Windows file system problem.

@SukkaW SukkaW mentioned this pull request Jul 25, 2020
Merged
22 tasks
@stevenjoezhang stevenjoezhang mentioned this pull request Dec 12, 2020
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@curbengh curbengh curbengh left review comments

@yoshinorin yoshinorin yoshinorin approved these changes

@tomap tomap Awaiting requested review from tomap

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@SukkaW @coveralls @yoshinorin @curbengh