feat: add a logger hook #1574
Draft
feat: add a logger hook #1574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hugocaillard
force-pushed
the
feat/session-logger-hook
branch
from
3132054
to
ab77a46
Compare
hugocaillard
force-pushed
the
feat/session-logger-hook
branch
from
ab77a46
to
5375a34
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The current way to retrieve the result of a
(print <value>)function call in the tests, is to retrieve the events.But, events are not emitted in read only functions calls or in failing public functions calls. Which is when logs are the most needed.
By using an evalhook, we can retrieve the value of the printed value and return it to the sdk so that it can be logged in JS