undef(resolve) adding Hoa namespace to resolve to avoid conflict #22
Conversation
|
Can you complete also the README please ? |
Wrapper.php
Outdated
| @@ -583,7 +583,7 @@ public function getStreamName() | |||
|
|
|||
| } | |||
|
|
|||
| namespace | |||
| @@ -902,7 +902,7 @@ protected function openDirectory(SUT $wrapper, array $children = []) | |||
| $wrapper->dir_opendir('hoa://Test/Vfs/Bar?type=directory', 0); | |||
|
|
|||
| foreach ($children as $child) { | |||
| resolve('hoa://Test/Vfs/Bar/' . $child . '?type=file'); | |||
There was a problem hiding this comment.
Hoa\Protocol\Protocol::getInstance()->resolve(…) is better.
| @@ -148,7 +148,7 @@ public function main() | |||
| ' is equivalent to:', "\n"; | |||
| } | |||
|
|
|||
| $resolved = resolve($path, $exists, $unfold); | |||
There was a problem hiding this comment.
Hoa\Protocol\Protocol::getInstance()->resolve(…) is better.
|
here it is |
|
We have to coordinate the release of this library with the drop of PHP 5.x because it introduces a BC break. Do you agree? |
|
Yes, because less bc break is good. But, I can wait. What do we need for breaking php compatibility? |
|
We must implement |
|
OK. |
|
Hey all! We've just implemented the Hoa\Ruler package in Laravel and this is causing some serious headaches for us as we have other packages using Laravel's Is there any update on when this will be released? Is it safe to just use |
|
Hey guys, when will you release this? Your libraries are still unusable with Laravel because of this resolve function! |
related to #18
once we have discuted about it, I will get back on other repository depending on this function.
note with php 5.6+ we can use
use function \Hoa\resolvein the import part