Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Python3 incompatibility in PatternGenerator #62

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Fix Python3 incompatibility in PatternGenerator #62

wants to merge 4 commits into from

Conversation

fcr
Copy link
Contributor

@fcr fcr commented Apr 5, 2020

In PatternGenerator self.channels().values() was not being converted to a list before accessing by index.

jbednar
jbednar approved these changes Nov 15, 2020
View reviewed changes
Copy link
Contributor

@jbednar jbednar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Ready to merge?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbednar jbednar jbednar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fcr @jbednar