remove margin:auto #788
Open
remove margin:auto #788
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leigh123linux
force-pushed
the
cinnamon_auto-margin
branch
from
4d42137
to
213483f
Compare
22 tasks
fossfreedom
referenced
this pull request
in arc-design/arc-theme
Nov 18, 2017
Upstream PR #788 - This avoids warning messages as margin:auto is not supported in cinnamon 3.4 and later
|
Many thanks @leigh123linux - this has been merged in our soft fork https://github.com/NicoHood/arc-theme . If you can, please help out maintaining the cinnamon section of the theme. cheers |
|
@fossfreedom Can you please merge those changes via PRs on the fork? this way we can track them better. My wish would be that I check your PRs and you mine. This way we know what each other did and review/quick check it also. At least a separate PR would make sense to me. |
|
Sure. Will do a hard reset and convert to PRs |
fossfreedom
referenced
this pull request
in arc-design/arc-theme
Nov 19, 2017
Upstream PR #788 - This avoids warning messages as margin:auto is not supported in cinnamon 3.4 and later
|
@leigh123linux Thanks! You can close this issue now, as it got merged in the new upstream: |
jnsh
pushed a commit
to jnsh/arc-theme
that referenced
this pull request
Mar 25, 2019
Upstream PR horst3180#788 - This avoids warning messages as margin:auto is not supported in cinnamon 3.4 and later
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has been removed in cinnamon-3.4
linuxmint/cinnamon@b579bbe