Upgrade playwright to 1.46.1 #1305
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radanskoric
force-pushed
the
radan-upgrade-playwright
branch
from
e32e9d0
to
256153b
Compare
It upgrades it in package.json and in the devcontainer setup. It's now set to a specific version because it needs to exactly match the playwright version which is declared in the devcontainer setup. The upgrade had to raise the node requirement to >= 18 because @playwright/test requires it.
radanskoric
force-pushed
the
radan-upgrade-playwright
branch
from
256153b
to
5c03d46
Compare
|
If someone is looking at this and would like to help merge this: it's almost done but there are a few failing tests after the upgrade. I've fixed one but I'm a bit stuck with the others. If you have an idea of what it might be please share to help me get this update finished. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It upgrades it in package.json and in the devcontainer setup.
It's now set to a specific version in package.json because it needs to exactly match the playwright version which is declared in the devcontainer setup.