Treat chain names as lowercase #2249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asaj
reviewed
May 22, 2023
|
@mattiecnvr should we merge this |
asaj
approved these changes
Jun 28, 2023
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #2249 +/- ##
=======================================
Coverage 64.71% 64.71%
=======================================
Files 83 83
Lines 1312 1312
Branches 171 171
=======================================
Hits 849 849
Misses 456 456
Partials 7 7 ☔ View full report in Codecov by Sentry. |
|
oops, I did make a commit to dedup but forgot auto merge was on. Will followup with a small PR. |
Merged
mattiekat
added a commit
that referenced
this pull request
Jul 3, 2023
### Description Missed this by accident from #2249 ### Drive-by changes None ### Related issues ### Backward compatibility _Are these changes backward compatible?_ Yes _Are there any infrastructure implications, e.g. changes that would prohibit deploying older commits using this infra tooling?_ None ### Testing _What kind of testing have these changes undergone?_ Unit Tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Had to do a little digging but I think this should fix not only the issue that was encountered but fully add support for whatever case they want, it will just treat it as lowercase but still display it correctly for their config paths.
The problem was that
HyperlaneDomainwas already lowercasing the name but we didn't lowercase the key that we used infrom_config_filteredfor the baseRawSettingsto look it up during parsing so we couldn't find the values.Drive-by changes
None
Related issues
Backward compatibility
Are these changes backward compatible?
Yes
Are there any infrastructure implications, e.g. changes that would prohibit deploying older commits using this infra tooling?
None
Testing
What kind of testing have these changes undergone?
None