update stem generation implementation #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Karim Taam <[email protected]>
8 tasks
|
Signed-off-by: Karim Taam <[email protected]>
Signed-off-by: Karim Taam <[email protected]>
| public Bytes32 storageKey(final Bytes address, final Bytes32 storageKey) { | ||
| final Bytes stem = getStorageStem(address, storageKey); | ||
| final UInt256 suffix = getStorageKeySuffix(storageKey); | ||
| return swapLastByte(stem, suffix); |
There was a problem hiding this comment.
There is something that I might be missing here.
It seems to me like stem is the 31-bytes prefix part of the trie-key that you get from hashing the address and storageKey.
Then, why would you need to swap the last byte ? I thought this was done on the 32nd (last) byte only.
To me, the storageKey would be just the concatenation here of stem and suffix.
| return swapLastByte(base, pos.mod(VERKLE_NODE_WIDTH)); | ||
| public Bytes32 codeChunkKey(final Bytes address, final UInt256 chunkId) { | ||
| final Bytes stem = getCodeChunkStem(address, chunkId); | ||
| return swapLastByte(stem, getCodeChunkKeySuffix(chunkId)); |
There was a problem hiding this comment.
I imagine the same as above here applies
| return swapLastByte(base, leafKey); | ||
| public Bytes32 headerKey(final Bytes address, final UInt256 leafKey) { | ||
| final Bytes stem = getHeaderStem(address); | ||
| return swapLastByte(stem, leafKey); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
Update stem generation code in order to keep only the first 31 bytes of the generated data.
Fixed Issue(s)