Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: supporting aggregation queries in visualization #2506

Merged
merged 4 commits into from
Nov 9, 2023

Conversation

palbizu
Copy link
Contributor

@palbizu palbizu commented Nov 9, 2023

Description

Supporting Aggregation queries in Visualization

Testing

Locally Tested.

Checklist:

  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Any dependent changes have been merged and published in downstream modules

Documentation

Make sure that you have documented corresponding changes in this repository or hypertrace docs repo if required.

@palbizu palbizu requested a review from a team as a code owner November 9, 2023 17:32

This comment has been minimized.

Copy link

codecov bot commented Nov 9, 2023

Codecov Report

Merging #2506 (69004f6) into main (1dc53b9) will increase coverage by 45.87%.
The diff coverage is 30.00%.

@@             Coverage Diff             @@
##             main    #2506       +/-   ##
===========================================
+ Coverage   37.11%   82.99%   +45.87%     
===========================================
  Files         925      925               
  Lines       20620    20636       +16     
  Branches     3257     3260        +3     
===========================================
+ Hits         7654    17127     +9473     
+ Misses      12362     3389     -8973     
+ Partials      604      120      -484     
Files Coverage Δ
...ore-query-editor/explore-query-editor.component.ts 97.67% <ø> (+88.37%) ⬆️
...arts/cartesian-widget/axis/cartesian-axis.model.ts 80.00% <100.00%> (+2.22%) ⬆️
...y/src/pages/explorer/explorer-dashboard-builder.ts 78.65% <71.42%> (+63.35%) ⬆️
...hql/explore/explore-cartesian-data-source.model.ts 80.00% <0.00%> (+63.09%) ⬆️
...d/dashboard/data/graphql/explore/explore-result.ts 88.52% <0.00%> (+77.41%) ⬆️

... and 415 files with indirect coverage changes

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

@palbizu palbizu merged commit 2fcae01 into main Nov 9, 2023
13 of 14 checks passed
@palbizu palbizu deleted the SupportingAggregationQueries branch November 9, 2023 20:15
Copy link

github-actions bot commented Nov 9, 2023

Unit Test Results

       4 files  ±0     316 suites  ±0   42m 54s ⏱️ - 4m 54s
1 131 tests ±0  1 131 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
1 141 runs  ±0  1 141 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 2fcae01. ± Comparison against base commit 1dc53b9.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants