Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: supporting aggregation queries in visualization #2506

Merged
merged 4 commits into from
Nov 9, 2023
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
feat: fixing comments
Patricio Albizu authored and Patricio Albizu committed Nov 9, 2023

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
commit b2d03dae3888691ac2041a5501c547860a7d5967
Original file line number Diff line number Diff line change
@@ -178,7 +178,7 @@ export abstract class ExploreCartesianDataSourceModel extends GraphQlDataSourceM
const metricAggregationData = result.getMetricAggregationSeriesData(spec.name, spec.aggregation);

return {
data: metricAggregationData?.value ? [['', metricAggregationData.value]] : [],
data: metricAggregationData.value ? [['', metricAggregationData.value]] : [],
spec: spec
};
}
Original file line number Diff line number Diff line change
@@ -82,11 +82,7 @@ export class ExploreResult {
): MetricAggregationData {
return {
key: spec.name,
...(result
? {
value: result?.[spec.resultAlias()].value as number
}
: {})
value: result?.[spec.resultAlias()].value as number
};
}

@@ -168,5 +164,5 @@ interface GroupData {

interface MetricAggregationData {
key: string;
value?: number;
value: number | undefined;
}