Fix so that the uriIsPrivate takes a str #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArneBab
reviewed
Aug 26, 2022
| @@ -3251,8 +3251,8 @@ def uriIsPrivate(uri): | |||
| if "/" in extra: | |||
| extra = extra.split("/")[0] | |||
| extra += "/" | |||
| extrabytes = base64.decodestring(extra) | |||
| isprivate = ord(extrabytes[1]) | |||
| extrabytes = base64.decodebytes(extra.encode()) | |||
There was a problem hiding this comment.
does this need an explicit encoding = "utf-8" argument?
There was a problem hiding this comment.
According to the help of str.encode 'utf-8' is the default encoding so adding encoding='utf-8' will not add any value.
Another question it if this could have some other encoding. It should be an URI and as such I assume it is limited to ASCII (32 - 126) or perhaps even (33-126) so any utf-coding will probably work just as well.
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is a fix to be able to enter the private URI when creating a site.
base64.decodestring is deprecated and replaced by decodebytes.