Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix so that the uriIsPrivate takes a str #32

Merged
merged 1 commit into from
Nov 4, 2022
Merged

Fix so that the uriIsPrivate takes a str #32

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions fcp3/node.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3251,8 +3251,8 @@ def uriIsPrivate(uri):
if "/" in extra:
extra = extra.split("/")[0]
extra += "/"
extrabytes = base64.decodestring(extra)
isprivate = ord(extrabytes[1])
extrabytes = base64.decodebytes(extra.encode())
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does this need an explicit encoding = "utf-8" argument?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to the help of str.encode 'utf-8' is the default encoding so adding encoding='utf-8' will not add any value.

Another question it if this could have some other encoding. It should be an URI and as such I assume it is limited to ASCII (32 - 126) or perhaps even (33-126) so any utf-coding will probably work just as well.

isprivate = extrabytes[1]
if isprivate:
return True
return False
Expand Down