New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Process mention on annotation creation #9322

Merged

mtomilov merged 1 commit into main from process-mention-on-annotation-creation

Feb 7, 2025

Contributor

mtomilov commented Feb 3, 2025 •

edited

Loading

Refs #9304

See testing instructions in the PoC #9279

Most everything has been addressed in the PoC

mtomilov force-pushed the process-mention-on-annotation-creation branch from cc37bf2 to 6dfab59 Compare

February 4, 2025 11:47

mtomilov marked this pull request as ready for review

February 4, 2025 14:54

mtomilov commented

View reviewed changes

h/models/mention.py Show resolved Hide resolved

mtomilov commented

View reviewed changes

h/presenters/mention_json.py Show resolved Hide resolved

mtomilov commented

View reviewed changes

h/services/annotation_write.py Outdated Show resolved Hide resolved

mtomilov commented

View reviewed changes

h/services/html.py Show resolved Hide resolved

mtomilov commented

View reviewed changes

tests/unit/h/services/mention_test.py Show resolved Hide resolved

mtomilov commented

View reviewed changes

tests/unit/h/services/annotation_json_test.py Show resolved Hide resolved

mtomilov commented

View reviewed changes

h/services/mention.py Show resolved Hide resolved

mtomilov commented

View reviewed changes

h/services/mention.py Show resolved Hide resolved

mtomilov added a commit that referenced this pull request


          Process mention on annotation creation #9322

mtomilov force-pushed the process-mention-on-annotation-creation branch from be88a11 to 7980259 Compare

February 5, 2025 11:17

mtomilov added a commit that referenced this pull request


          Process mention on annotation creation #9322

008f84f

mtomilov force-pushed the process-mention-on-annotation-creation branch from 7980259 to 008f84f Compare

February 5, 2025 11:20

mtomilov commented

View reviewed changes

h/services/mention.py Show resolved Hide resolved

mtomilov requested review from marcospri and acelaya

February 5, 2025 11:21

mtomilov added a commit that referenced this pull request


          Process mention on annotation creation #9322

42922ed

mtomilov force-pushed the process-mention-on-annotation-creation branch from 008f84f to 42922ed Compare

February 5, 2025 11:25

Contributor Author

mtomilov commented Feb 5, 2025

Not entirely sure if I need to add view / functional tests

mtomilov commented

View reviewed changes

tests/unit/h/services/mention_test.py Show resolved Hide resolved

acelaya reviewed

View reviewed changes

Contributor

acelaya left a comment

Looks good to me in general. My main feedback is that we should probably run the mentions-specific logic only if the at_mentions feature is enabled.

docs/_extra/api-reference/schemas/annotation.yaml Show resolved Hide resolved

h/services/annotation_json.py Outdated Show resolved Hide resolved

h/services/annotation_write.py Outdated Show resolved Hide resolved

h/services/mention.py Outdated Show resolved Hide resolved

mtomilov added a commit that referenced this pull request


          Process mention on annotation creation #9322

510fc62

mtomilov force-pushed the process-mention-on-annotation-creation branch from 42922ed to 510fc62 Compare

February 5, 2025 13:55

mtomilov added a commit that referenced this pull request


          Process mention on annotation creation #9322

5ce9754

mtomilov force-pushed the process-mention-on-annotation-creation branch from 510fc62 to 5ce9754 Compare

February 5, 2025 14:43

mtomilov added a commit that referenced this pull request


          Process mention on annotation creation #9322

85f0de1

mtomilov force-pushed the process-mention-on-annotation-creation branch from 5ce9754 to 85f0de1 Compare

February 5, 2025 14:45

marcospri approved these changes

View reviewed changes

Member

marcospri left a comment

Looks good 👍

I might have split this into two PRs, one for processing the mentions and another one to expose them the API (addressing the latest changes there).

But this PR comes after the PoC one so we are already familiar with the changes anyway. The API field name change can be addressed in a follow up PR as you say 👍

h/services/mention.py Show resolved Hide resolved

h/services/annotation_write.py Outdated Show resolved Hide resolved

h/services/mention.py Show resolved Hide resolved

acelaya approved these changes

View reviewed changes

mtomilov mentioned this pull request

Eargerly load user groups when updating mentions #9330

Open

mtomilov added a commit that referenced this pull request


          Process mention on annotation creation #9322

13181bc

mtomilov force-pushed the process-mention-on-annotation-creation branch from 85f0de1 to 13181bc Compare

February 6, 2025 17:41

mtomilov added a commit that referenced this pull request


          Process mention on annotation creation #9322

06563e6

mtomilov force-pushed the process-mention-on-annotation-creation branch from 13181bc to 06563e6 Compare

February 6, 2025 17:52


          Process mention on annotation creation #9322

dd7d8ee

mtomilov force-pushed the process-mention-on-annotation-creation branch from 06563e6 to dd7d8ee Compare

February 7, 2025 11:44

mtomilov merged commit a3a53e9 into main

11 checks passed

mtomilov deleted the process-mention-on-annotation-creation branch

February 7, 2025 11:47

mtomilov mentioned this pull request

Update mention json payload #9331

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet