Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable many more Ruff linter rules #6975

Closed
wants to merge 2 commits into from
Closed

Enable many more Ruff linter rules #6975

wants to merge 2 commits into from

Conversation

seanh
Copy link
Collaborator

@seanh seanh commented Jan 28, 2025

No description provided.

seanh added 2 commits January 28, 2025 13:24
These frequently get in the way of development (for example I've been
working on a PR to enable more Ruff linter rules, and it creates
violations in the BDD tests) but they provide little value (I can't
remember the last time a BDD test failed and pointed out a bug in the
code). Also, nobody wants to maintain these tests: they work completely
differentlyt from the rest of our unit and functional tests.
@seanh seanh requested a review from marcospri January 28, 2025 13:45
@seanh seanh changed the base branch from main to remove-bdd-tests January 28, 2025 13:45
@seanh seanh changed the title enable ruff rules Enable many more Ruff linter rules Jan 28, 2025
Base automatically changed from remove-bdd-tests to main January 31, 2025 11:17
@seanh
Copy link
Collaborator Author

seanh commented Feb 6, 2025

Closing in favour of #7006

@seanh seanh closed this Feb 6, 2025
@seanh seanh deleted the enable-ruff-rules branch February 6, 2025 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant