-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Theme bridge to v5.0.0
#2373
Open
r100-stack
wants to merge
54
commits into
r/private-css-vars
Choose a base branch
from
r/bridge
base: r/private-css-vars
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Theme bridge to v5.0.0
#2373
Changes from 50 commits
Commits
Show all changes
54 commits
Select commit
Hold shift + click to select a range
17f2f4d
🛫
r100-stack cd6e72c
Leftover
r100-stack 7a1a845
Partial fixes
r100-stack 44d3e9b
Fixed theme toggles
r100-stack 4b0836c
Merge branch 'r/private-css-vars' into r/bridge
r100-stack 7b35137
Fixes
r100-stack 950f796
Fixes
r100-stack 8b213e9
Cleanup
r100-stack ca20e05
Simplification
r100-stack ee51d4b
Leftover
r100-stack 3303613
Merge branch 'r/private-css-vars' into r/bridge
r100-stack ba8e6df
nit
r100-stack 7c778a1
Merge remote-tracking branch 'origin/r/private-css-vars' into r/bridge
r100-stack 864fbe2
`pnpm-lock.yml`
r100-stack 808056b
Comments
r100-stack cd9dedb
Remove `*` by unlayering
r100-stack a216d1b
no dep on
r100-stack 666f197
Comments
r100-stack 2e3e503
Fix layer order in css workshop
r100-stack 1375402
Re-add variables dep in react-workshop
r100-stack 65a0cba
Into separate layer
r100-stack 7733e97
Fix order
r100-stack 535ff3f
Text color from base to faded.
r100-stack 0a3b283
Border's "subtle" improvements.
r100-stack 677806b
Removed override for background-transparent-hover and field backgroun…
r100-stack f987e8b
Button improvements.
r100-stack c1c865b
Reorder bridge components overrides.
r100-stack d5910a4
Breadcrumbs remove overrides.
r100-stack 2be9fa8
Testing and simplifications
r100-stack 1eb5b25
Contrast improvements, TODOs
r100-stack de35da6
Merge branch 'r/private-css-vars' into r/bridge
r100-stack c45806f
Backgrounds, status borders, non-current breadcrumbs
r100-stack 2eb99bf
Button group fix
r100-stack 4ccd98c
scoping, few hsl variables
r100-stack b9d90ce
HSL, fix tree selection background and others.
r100-stack 55fbde0
nit
r100-stack 9307ef9
Bumping to dev version.
r100-stack 2199938
`future.themeBridge` prop
r100-stack 3dea59e
Comments
r100-stack a338de9
`bridge.scss` simplification
r100-stack 52020e8
Other comments
r100-stack af04c6d
Merge branch 'r/private-css-vars' into r/bridge
r100-stack 162008f
Leftover
r100-stack 52252cf
Bump `@astrojs/react`
r100-stack 0bcb005
Pass `future` to portal container
r100-stack 46eb69d
More comments
r100-stack be0762e
Remove unnecessary hardcoded theme
r100-stack 1412dac
More comments in bridge
r100-stack fc42aea
Default prop value for `future`
r100-stack 5ac59aa
Update `itwinui-react` dev version
r100-stack 338b866
Merge branch 'r/private-css-vars' into r/bridge
r100-stack 10dbfcd
Comment
r100-stack 98ad57a
Descriptive comments
r100-stack c26461a
Minimize CSS workshop changes
r100-stack File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
{ | ||
"extends": "astro/tsconfigs/base", | ||
"compilerOptions": { | ||
"jsx": "react-jsx", | ||
"jsxImportSource": "react" | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -8,6 +8,7 @@ | |
"@fontsource/noto-sans-mono": "5", | ||
"@itwin/itwinui-icons-react": "2.8.0", | ||
"@itwin/itwinui-variables": "*", | ||
"@itwin/itwinui-react-v5": "npm:@itwin/[email protected]", | ||
"@itwin/itwinui-react": "*", | ||
"@ladle/react": "^4.1.2", | ||
"@types/node": "*", | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similar comment here as Ladle: can we set all attributes on the same element (
<body>
or<html>
) instead of mixing and matching?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
iui-root
cannot be onhtml
sinceiui-root
sets afont-size
of0.875rem
(code) which would make the rootfont-size
as0.875rem
and not1rem
.We can set the data attributes on
html
without addingiui-root
as we are currently doing inreact-workshop
for the page background ((code)). However, theniui-root
+ its theme related data attributes will still need to be placed somewhere.To just have one place with the data attributes + the
iui-root
class, we chose<body>
as that place incss-workshop
.Regarding the selected lines, the reason we set
color-scheme
on<html>
and not<body>
is because when placed on<html>
those iTwinUI v5 variables are available throughout the page and not just within🥝-root
.