Fixed site documentation layout #2381
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smmr-dn
requested review from
mayank99 and
r100-stack
and removed request for
a team
r100-stack
reviewed
Dec 23, 2024
r100-stack
approved these changes
Dec 23, 2024
r100-stack
approved these changes
Dec 23, 2024
mayank99
reviewed
Dec 23, 2024
2 tasks
|
Closing this PR as it is no longer applicable (#2381 (comment)) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
The
display: block !importantcaused unexpected behaviors in live demo block in terms of width and height for some components. Especially, theTagcomponent got stretched out and ended up overlapping with the content table.This PR addressed another workaround, following Mayank's PR, to temporarily fix the problem caused by VoiceOver not working in Safari. Currently, Safari 18.3 beta version has been released, and this bug was marked as major so hopefully, we can remove this workaround soon.
Testing
Confirmed VoiceOver is still working in Safari.
Docs
N/A