-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use an inline-size container for <demo-box>
#2415
Use an inline-size container for <demo-box>
#2415
Conversation
Note: This PR supersedes #2381. |
Marking this as ready to review even though the tests are failing. Seems like it might be a GH configuration thing? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good fix, LGTM!
(Ignore the failing checks, it's a permissions thing)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🚀
Changes
For the docs site, this resolves the issues of the main content breaking out of its grid column on the page for the
Tag
component. Given that a demo’s content should be isolated from the page, it makes sense to make it aninline-size
container, so that the size of the content doesn’t affect the size of the parent — important when working with nested grid layouts.Some other changes needed to be made as a consequence of this:
100%
within their styles, I’ve swapped that for100cqi
.inline-size
containment applied.max-inline-size
of100cqi
to the<astro-island>
to force content to shrink in some cases (e.g.Header
).Testing
Every page that uses
<LiveExample>
will need to be tested/reviewed visually. Make sure to resize.Docs
N/A