-
-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Import/export improvements #573
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The config file vs define stuff looks good; I have no opinion (or ability to form an opinion) on the actual UnityGLTF itself
…port # Conflicts: # Assets/Scripts/Export/Export.cs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good from my POV, but I don't really have any substantive comments about UnityGLTF itself
Also, prior to merging this, delete the Package cache (as well as the Library caches). I just realized I might have implied only the library caches on discord. |
Side effect of #689 |
This reverts commit 33c86d6. It appears that this broke the loading of 3D models on the Quest
PR #573 introduced new bundles, and since they weren't signed, the DMG notarization failed. * Explicitly sign the ktx_unity.bundle and draco_unity.bundle * Sign all bundles in a loop, rather than listing them
Example "Export" block from the config showing defaults (ExportBinaryFbx and ExportFbxVersion are existing keys)