Fix batch methods for historical models #324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the default implementation, `cursor` defaults to `primary_key`, which is 'id'. However, for historical models, we need to use 'hid' instead of 'id'. This patch addresses an issue where `with_hid_pkey` is called after the cursor is already set, potentially leading to incorrect behavior. Notes: - `find_each` and `find_in_batches` use `in_batches` internally, however this is not enough anymore in the upcoming Rails 8.0 because there is a conditional branch using `enum_for` - This approach prevents specifying 'id' as a cursor for historical models. If 'id' is needed, it must be handled separately. Fix #321
tagliala
force-pushed
the
feature/321-find-each-edge
branch
from
04b7e5b
to
b7155a5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the default implementation,
cursordefaults toprimary_key, which is 'id'.However, for historical models, we need to use 'hid' instead of 'id'.
This patch addresses an issue where
with_hid_pkeyis called after the cursor is already set, potentially leading to incorrect behavior.Notes:
find_eachandfind_in_batchesusein_batchesinternally, however this is not enough anymore in the upcoming Rails 8.0 because there is a conditional branch usingenum_forFix #321