Commits on Aug 12, 2024

1. Fix batch methods for historical models …

   In the default implementation, `cursor` defaults to `primary_key`, which
   is 'id'.
   However, for historical models, we need to use 'hid' instead of 'id'.
   
   This patch addresses an issue where `with_hid_pkey` is called after the
   cursor is already set, potentially leading to incorrect behavior.
   
   Notes:
   - `find_each` and `find_in_batches` use `in_batches` internally, however
     this is not enough anymore in the upcoming Rails 8.0 because there is
     a conditional branch using `enum_for`
   - This approach prevents specifying 'id' as a cursor for historical
     models. If 'id' is needed, it must be handled separately.
   
   Fix #321

   

   tagliala committed Aug 12, 2024
   Configuration menu

   • View commit details
   • Copy full SHA for b7155a5
   • Browse repository at this point

   Copy the full SHA

   b7155a5 View commit details

   Browse the repository at this point in the history